Include additional fields for submission table, UI updates #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit b2f4abe and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 36.7% (0.9% change). View more on Code Climate. |
Coverage Report (Frontend)
|
TimCsaky
reviewed
Apr 3, 2024
app/src/controllers/submission.ts
Outdated
| queuePriority: parseInt(data.queuePriority), | ||
| singleFamilyUnits: maxUnits, | ||
| isRentalUnit: camelCaseToTitleCase(deDupeUnsure(data.isRentalUnit)), |
There was a problem hiding this comment.
'Unsure' is a pointless value.
maybe the CHEFS data should be converted true|false|null in the database. The postgres boolean type .. and prisma and joi.. support that.. (eg for knex table.boolean('isRentalUnit')
The isTruthy utils function might handle the deduping as well.
TimCsaky
reviewed
Apr 3, 2024
kyle1morel
previously approved these changes
Apr 3, 2024
kyle1morel
approved these changes
Apr 4, 2024
| */ | ||
| export function camelCaseToTitleCase(input: string | null): string | null { | ||
| if (!input) return input; | ||
|
|
jatindersingh93
approved these changes
Apr 4, 2024
kyle1morel
force-pushed
the
feature/submission-update
branch
from
f7bcf1b to
b2f4abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the following fields to the submission table:
contactPreference,contactApplicantRelationship,projectDescription,isRentalUnit.Functionality for updating those fields.
Updated labels for certain submission types.
SHOWCASE-3600
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments